Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: clean up imports #853

Merged
merged 1 commit into from
Jan 16, 2020
Merged

chore: clean up imports #853

merged 1 commit into from
Jan 16, 2020

Conversation

DucarrougeR
Copy link
Contributor

@DucarrougeR DucarrougeR commented Nov 7, 2019 •
edited
Loading

Fixes #X

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them
  • I updated my branch with the master branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

  • removes duplicated imports and non used imports

If you have questions, please send an email to Twilio SendGrid, or file a GitHub Issue in this repository.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Nov 7, 2019
@codecov
Copy link

codecov bot commented Nov 7, 2019 •
edited
Loading

Codecov Report

Merging #853 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #853   +/-   ##
=======================================
  Coverage   80.02%   80.02%           
=======================================
  Files          70       70           
  Lines        2018     2018           
  Branches      339      339           
=======================================
  Hits         1615     1615           
  Misses        204      204           
  Partials      199      199

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c500f4...12d01c9. Read the comment docs.

@eshanholtz eshanholtz changed the title clean up imports chore: clean up imports Jan 16, 2020
@eshanholtz eshanholtz added difficulty: easy fix is easy in difficulty type: getting started question while getting started status: ready for deploy code ready to be released in next deploy and removed status: code review request requesting a community code review or review from Twilio labels Jan 16, 2020
@eshanholtz eshanholtz merged commit bffb267 into sendgrid:master Jan 16, 2020
@thinkingserious
Copy link
Contributor

Hello @DucarrougeR,

Thanks again for the PR!

We want to show our appreciation by sending you some swag. Could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@DucarrougeR
Copy link
Contributor Author

Hey @thinkingserious, thank you!

@DucarrougeR DucarrougeR deleted the patch-1 branch January 17, 2020 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eshanholtz eshanholtz eshanholtz approved these changes

Assignees
No one assigned
Labels
difficulty: easy fix is easy in difficulty status: ready for deploy code ready to be released in next deploy type: getting started question while getting started
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DucarrougeR @thinkingserious @eshanholtz